Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shut down kernels after running the tests #242

Merged
merged 2 commits into from
Jun 14, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 14, 2019

Fixes #231.

Two changes:

  • Add a stop method to VoilaApp to shut down the kernels
  • Call that method when in the tests before clearing the voila_app instance

It's probably simple enough for now to fix the issue, but we might want to reconsider this approach later on especially regarding pytest-tornado (as pointed out by @martinRenou in #231)

@martinRenou
Copy link
Member

Mmmmh. Tests are failing on my side. But I would not trust my conda environment this time :P Better trust the CI

@jtpio
Copy link
Member Author

jtpio commented Jun 14, 2019

Do the tests run in a new fresh environment, after running python -m pip install ".[test]" (without the -e) and installing the test_template?

@maartenbreddels
Copy link
Member

LGTM

@maartenbreddels maartenbreddels merged commit 7164dc5 into voila-dashboards:master Jun 14, 2019
@maartenbreddels
Copy link
Member

@martinRenou I'm assuming that is the case indeed :)

@jtpio jtpio deleted the tests-stop-kernels branch June 14, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running the tests locally doesn't clean up kernels
3 participants