-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deploy documentation for heroku and app engine #229
add deploy documentation for heroku and app engine #229
Conversation
Thanks @RensDimmendaal! We will definitely review this soon! |
Thanks for writing this! I had a look at the heroku part. It looks great! I had a couple of thoughts:
For instance, a sentence like the following would be useful at the end:
Regardless of what we choose, I think it's important to give guidance as to where to deploy for users with little prior experience. A sentence like the following at the beginning would be appropriate:
|
Thanks for the feedback @pbugnion. I've implemented all your suggestions |
Thanks! I think the Heroku parts look great. I've made one more tiny comment. It might be useful for someone with experience deploying on GCP to review those parts (@jtpio ?) |
Thanks @RensDimmendaal! I haven't tried GCP yet but I think @maartenbreddels mentioned something about it and might be able to have a look. Also referencing @martinRenou's standalone example for deploying voila on Heroku: https://github.com/martinRenou/voila_heroku |
docs/source/deploy.rst
Outdated
|
||
If you are not sure where to deploy your app, we suggest Heroku. You can test | ||
deploying and serving your app without having to enter any credit card details, | ||
and with very little prior experience of deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is giving a WARNING: Unexpected indentation
error when trying locally.
and with very little prior experience of deployments. | |
and with very little prior experience of deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. I dont' use a linter for the docs. What linter do you use? Maybe it would be a good idea to add it to the doc-requirements?
@RensDimmendaal I went through (and tested) the steps to deploy to App Engine. Left a few comments and fixes, but overall it looks good! |
Very well written, I can confirm that the steps work as well for GEA, except that it's very flakey (websocket has trouble connecting). |
@maartenbreddels it looks like these changes were implemented in the last two commits. So it should be ready to go. |
Hi, I'm trying to deploy according to instructions and I have the following error: (heroku logs --tail) Help!! 2019-11-26T22:27:06.000000+00:00 app[api]: Build succeeded |
@juanfranciscomunoz the logs say:
Where |
Can someone tell how to deploy voila in GCP? |
I've taken a stab at creating deployment instructions. Cheers.
Mentions in issues: