Add nbconvert version check

[trungleduc]

References

Due to the non-backward compatible change in nbconvert 7.6.0 on markdown rendering, VoilaMarkdownRenderer class needs to be aware of the nbconvert version.

Code changes

User-facing changes

Backwards-incompatible changes

[github-actions]

👈 Launch a Binder on branch trungleduc/voila/fix-ci

[martinRenou]

How does it work? Doesn't this fail with an import error with prior versions?

[trungleduc]

indeed, my error. Updated to check for the nbconvert version

[trungleduc]

Added a test for nbconvert< 7.6.0

[SylvainCorlay]

Should this be backported?

[github-actions]

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table

Test file	voila-tree-classic.ipynb	voila-tree-light.ipynb	voila-tree-dark.ipynb	voila-tree-miami.ipynb	basics.ipynb	bqplot.ipynb	dashboard.ipynb	gridspecLayout.ipynb	interactive.ipynb	ipympl.ipynb	mimerenderers.ipynb	bokeh.ipynb	multiple_widgets.ipynb	query-strings.ipynb	reveal.ipynb
Render
chromium
actual	105 <- [112 - 126 - 147] -> 194	79 <- [83 - 84 - 96] -> 115	86 <- [92 - 100 - 119] -> 162	95 <- [101 - 110 - 121] -> 163	3187 <- [3336 - 3435 - 3617] -> 4866	2876 <- [2903 - 2976 - 3143] -> 3529	3246 <- [3334 - 3369 - 3426] -> 3629	3265 <- [3268 - 3279 - 3408] -> 3831	2460 <- [2464 - 2492 - 2604] -> 2885	4139 <- [4324 - 4506 - 4551] -> 5261	9253 <- [9394 - 9445 - 9608] -> 9721	4539 <- [4561 - 4599 - 4695] -> 5314	4948 <- [4961 - 5008 - 5174] -> 5505	2134 <- [2193 - 2222 - 2438] -> 2664	3413 <- [3419 - 3512 - 3639] -> 3823
expected	3379 <- [3442 - 3517 - 3701] -> 3876	2976 <- [3227 - 3321 - 3421] -> 3604	3608 <- [3623 - 3709 - 3793] -> 3825	4453 <- [4453 - 4523 - 4661] -> 4748	2559 <- [2655 - 2656 - 2660] -> 2674	3982 <- [4079 - 4213 - 4356] -> 4743	12183 <- [18509 - 19553 - 20811] -> 21515	15319 <- [15660 - 15796 - 15912] -> 16056	1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed

--- /dev/fd/63	2023-06-23 10:50:31.397103774 +0000
+++ /dev/fd/62	2023-06-23 10:50:31.401103923 +0000
@@ -4,51 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "112.0.5615.29"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8171M",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 36700160
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
-      "efficiencyCores": 0,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
-      "manufacturer": "Intel",
-      "model": "85",
-      "performanceCores": 2,
+      "manufacturer": "Intel®",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.6,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "4",
-      "vendor": "Intel",
+      "stepping": "2",
+      "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7268679680
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1040-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.2 LTS",
-      "serial": "b53da094229547778a51a873666147e4",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

[trungleduc]

It looks like GitHub is running out of osx runner

[trungleduc]

Should this be backported?

Yes, only to 0.4.x since 0.3.x works with nbconvert <7

[martinRenou]

Thanks! Let's not wait for the OSX build

[trungleduc]

@meeseeksdev please backport to 0.4.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 0.4.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 f416ab5134cee990920d157f333103d6873dcc34

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #1333: Add nbconvert version check'

4. Push to a named branch:

git push YOURFORK 0.4.x:auto-backport-of-pr-1333-on-0.4.x

5. Create a PR against branch 0.4.x, I would have named this PR:

"Backport PR #1333 on branch 0.4.x (Add nbconvert version check)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.