Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off debug mode and remove warnings for many_iopub_messages_test.py #1045

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Dec 15, 2021

This PR aims to eliminate the flaky tests by 3 changes:

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 3259 <- [3295 - 3375 - 3681] -> 4395 2910 <- [2951 - 3007 - 3034] -> 3541 3267 <- [3286 - 3377 - 3410] -> 3765 4238 <- [4270 - 4373 - 4413] -> 4800 2320 <- [2350 - 2424 - 2459] -> 2700 4816 <- [4912 - 5131 - 5545] -> 6651 11832 <- [11847 - 11933 - 12034] -> 12237 13822 <- [13868 - 13965 - 14012] -> 14083 1450 <- [1591 - 1594 - 1649] -> 1660 2780 <- [2805 - 2884 - 3001] -> 3127
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-12-15 16:25:05.354566920 +0000
+++ /dev/fd/62	2021-12-15 16:25:05.354566920 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7289614336
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.11.0-1022-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "176d176198ea43028bfd21edea1d38d5",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc trungleduc marked this pull request as ready for review December 15, 2021 17:06
@trungleduc
Copy link
Member Author

cc @jtpio if you want to take a look.

@jtpio
Copy link
Member

jtpio commented Dec 16, 2021

Thanks @trungleduc!

Turn off debug mode

Probably this was generating too much output?

@jtpio jtpio added this to the 0.3.x milestone Dec 16, 2021
@trungleduc
Copy link
Member Author

trungleduc commented Dec 16, 2021

Probably this was generating too much output?

Yes, a lot of output like :

...
[VoilaTest] activity on 9012bbf7-a4aa-4dea-b786-2011bed72ed4: display_data
[VoilaTest] activity on 9012bbf7-a4aa-4dea-b786-2011bed72ed4: display_data
[VoilaTest] activity on 9012bbf7-a4aa-4dea-b786-2011bed72ed4: display_data
[VoilaTest] activity on 9012bbf7-a4aa-4dea-b786-2011bed72ed4: display_data
...

and same for the warnings, it feels like the tests are more unstable if pytest generates too much messages

@trungleduc
Copy link
Member Author

Re-ran the jobs 3 times and all green, let's hope the same thing goes for main

@jtpio
Copy link
Member

jtpio commented Dec 16, 2021

OK sounds good then.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 41ad079 into voila-dashboards:main Dec 16, 2021
@jtpio
Copy link
Member

jtpio commented Dec 16, 2021

This might also fix #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants