Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests on Windows #1013

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Enable tests on Windows #1013

merged 2 commits into from
Oct 26, 2021

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Oct 25, 2021 •
edited
Loading

@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch trungleduc/voila/ci-add-windows)

@trungleduc
Copy link
Member Author

Failed tests are not related. It should be fixed in another PR

This was referenced Oct 25, 2021
Closed
Closed
@martinRenou
Copy link
Member

martinRenou commented Oct 26, 2021 •
edited
Loading

Does it work to only add windows-latest on this line? This way we can reuse the other job implementation.

@trungleduc
Copy link
Member Author

I don't think it will work, the bash invoking command and env. variables setup are different in windows.

@martinRenou
Copy link
Member

Ok :) Other than that it looks good to me

@martinRenou martinRenou merged commit b29251d into voila-dashboards:main Oct 26, 2021
@jtpio jtpio added this to the 0.3.0 milestone Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Hotpooling hanging when using Windows
3 participants
@trungleduc @martinRenou @jtpio