Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Enable Rust builtin_profiler #32362

Closed
wants to merge 2 commits into from
Closed

Conversation

s34m
Copy link

@s34m s34m commented Aug 6, 2021

…ithout it

General

Have the results of the proposed changes been tested?

  • [ x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Does it build and run successfully?

(Please choose at least one native build and, if supported, at least one cross build. More are better.)

  • [x ] I built this PR locally for my native architecture, (x86_64-GLIBC)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • armv7l
    • armv6l-musl

[ci skip]

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the commit message, the title is too long.

srcpkgs/rust/template Outdated Show resolved Hide resolved
@s34m s34m changed the title rust: Enable Rust builtin_profiler, some cargo crates fail to build w… rust: Enable Rust builtin_profiler Aug 6, 2021
@ericonr
Copy link
Member

ericonr commented Aug 6, 2021

You only fixed the PR title, not the commit itself.

@ericonr
Copy link
Member

ericonr commented Aug 19, 2021

Per rust-lang/rust#79121, this is still an unstable feature, and I don't think we should enable it in our distro toolchain. You probably want to use the rustup package and download nightly toolchains instead.

@ericonr ericonr closed this Aug 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants