Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xbps-src: add sccache support #30702

Closed
wants to merge 1 commit into from

Conversation

Logarithmus
Copy link
Contributor

@Logarithmus Logarithmus commented May 6, 2021

This PR adds support for using sccache when building cargo crates with xbps-src, just like ccache.
Unfortunately, this PR is blocked by #29756.

Roadmap:

srcpkgs/base-chroot/template Outdated Show resolved Hide resolved
@Piraty
Copy link
Member

Piraty commented May 6, 2021

interesting. i looked into icecc for xbps-src myself, scache could be a viable alternative.

@Logarithmus Logarithmus force-pushed the xbps-sccache branch 2 times, most recently from e053e08 to 7525d3b Compare May 6, 2021 12:47
common/build-helper/rust.sh Outdated Show resolved Hide resolved
@Johnnynator
Copy link
Member

This will blow up once you run parallel builds in different masterdirs. sccache always listens on some tcp port on localhost. You would need to figure out how to either allocate a TCP port per masterdir or implement the communication via unix sockets and upstream it.

@Logarithmus
Copy link
Contributor Author

This will blow up once you run parallel builds in different masterdirs. sccache always listens on some tcp port on localhost. You would need to figure out how to either allocate a TCP port per masterdir or implement the communication via unix sockets and upstream it.

I should definitely test this scenario. I still think this PR can be merged in its current state, because $XBPS_SCCACHE is turned off by default. Maybe I should add a disclaimer in README.md about parallel builds in differrent masterdirs though.

@ericonr
Copy link
Member

ericonr commented May 6, 2021

  • how faster do builds get?
  • does it work for cooperation between different packages using the same crate?
  • I'm against the need to install the package manually, it should be automated in some way (I suggested a solution above)

And it can't be merged if it's waiting on another PR.

@Logarithmus
Copy link
Contributor Author

  • how faster do builds get?
  • does it work for cooperation between different packages using the same crate?
  • I'm against the need to install the package manually, it should be automated in some way (I suggested a solution above)

And it can't be merged if it's waiting on another PR.

  • I'll perform some benchmarks and share the results.
  • I think it caches crates across different packages, but more testing is needed to proof that.
  • OK, I'll try adding rust_bootstrap into xbps-src, just like you've suggested in xbps-src: add sccache support #30702 (comment)

@Logarithmus Logarithmus marked this pull request as draft May 7, 2021 13:36
@ericonr ericonr added the xbps-src xbps-src related label May 9, 2021
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale xbps-src xbps-src related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants