Resource tree selector refactor #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will introduce a new logic into the resource tree selector component in order to allow users to be able to select Clusters within folders and also non-vic ResourcePools
This was referenced Jul 5, 2018
jooskim
approved these changes
Jul 5, 2018
There was a problem hiding this comment.
Looked through most part of the code and it looked good to me. Thanks for the refactoring work @javierfz1980 . As you noted, the API seems doesn't seem yet ready so let's wait until API is ready.
lmalvins
approved these changes
Jul 5, 2018
|
Was this re-tested following the merge of vmware/vic#8181? |
zhoumeina
pushed a commit
to zhoumeina/vic-ui
that referenced
this pull request
Aug 30, 2018
This change will introduce a new logic into the resource tree selector component in order to allow users to be able to select Clusters within folders and also non-vic ResourcePools
zhoumeina
added a commit
that referenced
this pull request
Aug 31, 2018
…sters in create vch vizard. (#581) * Resource tree selector refactor (#561) This change will introduce a new logic into the resource tree selector component in order to allow users to be able to select Clusters within folders and also non-vic ResourcePools * Fix missed service provider VicVmViewService in the app module (#579) This will add a missing service provider VicVmViewService that should be added to the root app Module in order to fix VIC summary view plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will introduce a new logic into the resource tree selector component in order to allow users to be able to select Clusters within folders and also non-vic ResourcePools
NOTE: This is still pending to be manually tested and merged till API changes are fixed and merged into master: vmware/vic#6711
Fixes #468
PR acceptance checklist:
[ x ] All unit tests pass
[ n/a ] All e2e tests pass
[ x ] Unit test(s) included*
[ n/a ] e2e test(s) included*
[ n/a ] Screenshot attached and UX approved*
*if applicable, add n/a if not