during restore, try to get backup directly from obj storage if not in cache/API #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
force-pushed
the
restore_missing_backup_fix
branch
from
db74f5e
to
17cecc3
Compare
skriss
changed the title
ncdc
reviewed
Sep 5, 2017
pkg/controller/restore_controller.go
Outdated
| backup, objErr = controller.backupService.GetBackup(bucket, name) | ||
| if objErr != nil { | ||
| glog.V(4).Infof("Backup %q not found in object storage.", name) | ||
| // return the original lister error |
There was a problem hiding this comment.
Wouldn't it make more sense to return this error?
There was a problem hiding this comment.
yeah, i guess so - was originally thinking that in the case where the user just typo-ed the backup name, the first error might make more sense, but the second is actually fine. minor thing either way.
pkg/controller/restore_controller.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| backup.ResourceVersion = "" |
There was a problem hiding this comment.
Add a comment that we have to clear RV in order to be able to do a create?
pkg/controller/restore_controller.go
Outdated
| backup.ResourceVersion = "" | ||
| created, createErr := controller.backupClient.Backups(api.DefaultNamespace).Create(backup) | ||
| if createErr != nil { | ||
| glog.V(4).Infof("Unable to create API object for backup %q: %v", name, createErr) |
There was a problem hiding this comment.
This probably should be at the error level
| name string | ||
| backupName string | ||
| informerBackups []*api.Backup | ||
| backupSvcBackups map[string][]*api.Backup |
There was a problem hiding this comment.
I'd like to move to mocks instead of fake services, but we don't have to do it as part of this PR
|
LGTM - please squash & we'll merge after jenkins |
skriss
force-pushed
the
restore_missing_backup_fix
branch
from
0ce30d5
to
0cdb33a
Compare
|
Argh, gotta fix a test error msg. |
… cache/API Signed-off-by: Steve Kriss <steve@heptio.com>
skriss
force-pushed
the
restore_missing_backup_fix
branch
from
0cdb33a
to
f07a70c
Compare
dymurray
pushed a commit
to dymurray/velero
that referenced
this pull request
May 8, 2020
Added support for restic --verify flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… cache/API
Signed-off-by: Steve Kriss steve@heptio.com
Fixes #42