Add credential file store in the backup deletion controller. #5521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Jiang blackpiglet@gmail.com
Thank you for contributing to Velero!
Please add a summary of your change
Add credential store in backup deletion controller to support VSL credential.
I followed these steps of v1.10 Velero manual test to verify VSL credential feature.
After BSL and VSL's credential modification, backup can be created successfully, but backup deletion would fail with something similar to "unable to read credential from environment variable GOOGLE_APPLICATION_CREDENTIALS".
This is caused by BackupDeletionController didn't have the secret credetial store to read secret. I didn't trigger this error during GCP supporting VSL credential PR, because BSL's credential is not modified during verification.
Does your change fix a particular issue?
Fixes #4862
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.