Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade velero docker image to use go 1.18 #5459

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

Lyndon-Li
Copy link
Contributor

@Lyndon-Li Lyndon-Li commented Oct 18, 2022

Upgrade velero docker image to use go 1.18 and upgrade golangci-lint to 1.45.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #5459 (162680b) into main (6b2cb7a) will increase coverage by 0.04%.
The diff coverage is 27.90%.

@@            Coverage Diff             @@
##             main    #5459      +/-   ##
==========================================
+ Coverage   40.52%   40.56%   +0.04%     
==========================================
  Files         236      236              
  Lines       20482    20484       +2     
==========================================
+ Hits         8300     8310      +10     
+ Misses      11572    11565       -7     
+ Partials      610      609       -1     
Impacted Files Coverage Δ
pkg/archive/extractor.go 0.00% <0.00%> (ø)
pkg/cmd/cli/backup/describe.go 0.00% <0.00%> (ø)
pkg/cmd/cli/backuplocation/create.go 31.42% <0.00%> (ø)
pkg/cmd/cli/backuplocation/delete.go 0.00% <0.00%> (ø)
pkg/cmd/cli/backuplocation/set.go 0.00% <0.00%> (ø)
pkg/cmd/cli/nodeagent/server.go 12.50% <0.00%> (ø)
pkg/cmd/server/server.go 6.58% <0.00%> (ø)
pkg/cmd/util/output/backup_describer.go 0.00% <0.00%> (ø)
pkg/cmd/util/output/output.go 0.00% <ø> (ø)
pkg/cmd/util/output/restore_describer.go 0.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lyndon-Li Lyndon-Li added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 18, 2022
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li force-pushed the velero-docker-image-go-1.18 branch 4 times, most recently from bcd9cb2 to f17e59d Compare October 18, 2022 13:47
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li force-pushed the velero-docker-image-go-1.18 branch 2 times, most recently from 3e772fd to 0b39fd6 Compare October 18, 2022 14:29
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@Lyndon-Li Lyndon-Li removed the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 18, 2022
@Lyndon-Li Lyndon-Li marked this pull request as ready for review October 18, 2022 14:42
@Lyndon-Li
Copy link
Contributor Author

The old version of golangci-lint doesn't work with go 1.18, so need to upgrade it as well.

Signed-off-by: lyndon <98304688+Lyndon-Li@users.noreply.github.com>
@Lyndon-Li Lyndon-Li merged commit 4d85b78 into vmware-tanzu:main Oct 19, 2022
@Lyndon-Li Lyndon-Li mentioned this pull request Oct 19, 2022
@Lyndon-Li Lyndon-Li deleted the velero-docker-image-go-1.18 branch December 1, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants