Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backupController's UT to test the prepareBackupRequest() method BackupStorageLocation processing logic #5362

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

niulechuan
Copy link
Contributor

@niulechuan niulechuan commented Sep 20, 2022

Please add a summary of your change

Added backupController's UT to test the prepareBackupRequest() method BackupStorageLocation processing logic. This important test was missing in the original UT.

The current test for prepareBackupRequest() is:
1. Test the backupLocationLabel is set correctly. lack of error msg testing, non-default backupStorageLocaltion testing.
2. Is backupTTL set correctly.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

… BackupStorageLocation processing logic

Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
@codecov-commenter
Copy link

Codecov Report

Merging #5362 (a5f1e7a) into main (ac2bb3e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5362   +/-   ##
=======================================
  Coverage   40.61%   40.61%           
=======================================
  Files         234      234           
  Lines       20293    20293           
=======================================
  Hits         8241     8241           
  Misses      11450    11450           
  Partials      602      602           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@niulechuan
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 21, 2022
Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@reasonerjt reasonerjt merged commit c83447f into vmware-tanzu:main Sep 26, 2022
@niulechuan niulechuan deleted the add-backup-controller-ut branch September 26, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants