validate cloud-provider config at startup & make PVProvider optional #35
Conversation
skriss
force-pushed
the
server_config_validation
branch
from
dfc4ed9
to
b8639e9
Compare
| } | ||
|
|
||
| if res == nil { | ||
| return nil, fmt.Errorf("zone not found for project %s: %s", project, zone) |
There was a problem hiding this comment.
How about zone %q not found for project %q?
pkg/controller/gc_controller.go
Outdated
| @@ -115,6 +115,12 @@ func (c *gcController) cleanBackups() { | |||
| } | |||
|
|
|||
| for _, volumeBackup := range backup.Status.VolumeBackups { | |||
| if c.snapshotService == nil { | |||
| glog.Warningf("Cannot garbage-collect snapshot %s for %backup s/%s because server is not configured with PersistentVolumeProvider", | |||
There was a problem hiding this comment.
typo: %backup s/%s
If the snapshot service is nil, the net result is that backups will be GC'd but associated snapshots will be orphaned?
There was a problem hiding this comment.
yes. it's a strange situation to be in - you created backups with snapshots, meaning you had a snapshotservice configured, but now you're in a mode where if you restore from them you won't use them. i suppose the alternative is to not GC any backups with snapshots in this scenario - WDYT?
There was a problem hiding this comment.
Maybe let's split out this last commit into a different PR so we can get the config validation in while we continue to discuss the optional PVProvider?
Signed-off-by: Steve Kriss <steve@heptio.com>
Signed-off-by: Steve Kriss <steve@heptio.com>
skriss
force-pushed
the
server_config_validation
branch
from
b8639e9
to
3ea3132
Compare
|
Removed commit to make PVProvider optional; will submit in a separate PR. Changed error messages per comment. |
|
Can you squash the last 2 commits together and then we'll merge? |
Signed-off-by: Steve Kriss <steve@heptio.com>
skriss
force-pushed
the
server_config_validation
branch
from
3ea3132
to
726bbbb
Compare
|
squashed. |
Wait for snapshot to be ready before restoring
@ncdc PTAL