Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable support for ppc64le architecture #1605

Merged
merged 3 commits into from
Jul 9, 2019
Merged

enable support for ppc64le architecture #1605

merged 3 commits into from
Jul 9, 2019

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Jun 26, 2019

Signed-off-by: Prajyot Parab Prajyot.Parab@ibm.com

Fixes #1493

root added 2 commits June 26, 2019 10:37
Signed-off-by: root <root@prajyot-ppc-velero-client.novalocal>
Signed-off-by: root <root@prajyot-ppc-velero-client.novalocal>
@skriss
Copy link
Member

skriss commented Jun 26, 2019

@Prajyot-Parab are you intending for us to publish ppc64le docker images? It looks like this PR as-is will publish the ppc64le binaries for releases on GitHub, but won't publish the docker images, just adds support for building them -- this is fine with me, just checking on what your intention is.

If you are looking for us to publish images, we might want to consider publishing a multi-arch image using fat manifests, but we can discuss further.

@Prajyot-Parab
Copy link
Contributor Author

@Prajyot-Parab are you intending for us to publish ppc64le docker images? It looks like this PR as-is will publish the ppc64le binaries for releases on GitHub, but won't publish the docker images, just adds support for building them -- this is fine with me, just checking on what your intention is.

If you are looking for us to publish images, we might want to consider publishing a multi-arch image using fat manifests, but we can discuss further.

@skriss getting velero images published for the ppc64le arch would be really helpful. Let me know your thoughts on the same.

@clnperez
Copy link

We'd love to have the fat manifest support and can help with that if needed. Maybe in a separate PR?

@jwcroppe
Copy link

@skriss Following up from @clnperez's and @Prajyot-Parab's previous comments - what do you see as next steps? Merge this and then have a separate PR for handling the Docker images and fat manifest, or is there another route we should take?

@jwcroppe
Copy link

jwcroppe commented Jul 7, 2019

@skriss Whenever you get a moment, just a quick follow up regarding your thoughts on the above proposal? Thanks in advance!

@skriss
Copy link
Member

skriss commented Jul 8, 2019

what do you see as next steps? Merge this and then have a separate PR for handling the Docker images and fat manifest, or is there another route we should take?

That works for me. I'll take another look through this one as-is shortly.

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments but mostly looks good.

.goreleaser.yml Show resolved Hide resolved
Dockerfile-fsfreeze-pause-ppc64le Outdated Show resolved Hide resolved
Dockerfile-velero-ppc64le Outdated Show resolved Hide resolved
Dockerfile-velero-restic-restore-helper-ppc64le Outdated Show resolved Hide resolved
Signed-off-by: Prajyot-Parab <Prajyot.Parab@ibm.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @nrb or @carlisia please take one more look.

@nrb nrb merged commit 7724464 into vmware-tanzu:master Jul 9, 2019
@rposts rposts mentioned this pull request Aug 13, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ppc64le (power architecture)
5 participants