Add --include-cluster-resources flag for restores #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
force-pushed
the
restore-inc-cluster-resources-flag
branch
from
f37fd45
to
9c4e15a
Compare
ncdc
reviewed
Oct 20, 2017
pkg/restore/restore_test.go
Outdated
| @@ -394,6 +401,24 @@ func TestRestoreResourceForNamespace(t *testing.T) { | |||
| restorers: map[schema.GroupResource]restorers.ResourceRestorer{schema.GroupResource{Resource: "foo-resource"}: newFakeCustomRestorer()}, | |||
| expectedObjs: toUnstructured(newTestConfigMap().WithArkLabel("my-restore").ConfigMap), | |||
| }, | |||
| // NEW | |||
skriss
force-pushed
the
restore-inc-cluster-resources-flag
branch
from
9c4e15a
to
b7d8ef5
Compare
|
@skriss I was just thinking that if you're creating a |
|
Or make it an optional bool (pointer) |
|
Yeah, I think defaulting to include makes sense. I think I like using an optional bool that defaults to true if not specified better; it's more consistent with the corresponding flag on backups. |
|
Yeah, let's go with the optional bool that defaults to true. |
skriss
force-pushed
the
restore-inc-cluster-resources-flag
branch
2 times, most recently
from
440d12c
to
59b4ec9
Compare
Signed-off-by: Steve Kriss <steve@heptio.com>
…rue) Signed-off-by: Steve Kriss <steve@heptio.com>
skriss
force-pushed
the
restore-inc-cluster-resources-flag
branch
from
59b4ec9
to
a7cc587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136