Document install command #1376
Document install command #1376
Conversation
nrb
changed the title
There was a problem hiding this comment.
Couple general comments:
-
L22-24 - we should update this text, since (I think) we'll no longer include install YAMLs in the tarball. Still worth recommending an official release, though.
-
L110-111 - this links looks stale, I believe the new link is: https://cloud.google.com/kubernetes-engine/docs/how-to/role-based-access-control#iam-rolebinding-bootstrap. Also, it's only relevant for
v1.11.xand older - we should note that. Also, I'm thinking this doesn't need its own section - let's just roll it into theInstall and start Velerosection.
docs/gcp-config.md
Outdated
|
|
||
| * In file `config/gcp/05-backupstoragelocation.yaml`: | ||
|
|
||
| * Replace `<YOUR_BUCKET>`. See the [BackupStorageLocation definition][7] for details. | ||
|
|
||
| * (Optional) If you run the nginx example, in file `config/nginx-app/with-pv.yaml`: |
There was a problem hiding this comment.
I'm thinking that since the install flow is different now, we should move any steps around installing the nginx sample into it's own section at the bottom, noted as (Optional).
docs/restic.md
Outdated
| @@ -23,7 +23,6 @@ cross-volume-type data migrations. Stay tuned as this evolves! | |||
|
|
|||
| ### Prerequisites | |||
|
|
|||
| - A working install of Velero version 0.10.0 or later. See [Set up Velero][2] | |||
| - A local clone of [the latest release tag of the Velero repository][3] | |||
There was a problem hiding this comment.
I don't think this is needed anymore
|
Two other thoughts - (a) we should probably reference the helm chart as an alternate means of installing, and (b) we should note that |
|
Yes and yes :) |
|
@skriss This link (https://cloud.google.com/kubernetes-engine/docs/how-to/role-based-access-control#prerequisites_for_using_role-based_access_control) works for me - did you mean the info was stale? |
|
The page still exists, but the anchor has been changed |
nrb
changed the title
|
I think the only outstanding comments are on restic.md |
docs/restic.md
Outdated
| @@ -29,14 +29,9 @@ cross-volume-type data migrations. Stay tuned as this evolves! | |||
|
|
|||
| 1. Ensure you've [downloaded latest release][3]. | |||
|
|
|||
| 1. Install Velero with restic support | |||
| 1. Install Velero with restic support: | |||
There was a problem hiding this comment.
let's just delete "Install Velero with restic support:" and move the following sentence up to be the content of #2.
Also - In the note below on RancherOS, can you indent the path lines under hostPath?
|
@nrb if you address #1376 (comment) I think we can get this merged. |
|
you want to squash? |
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
|
Squashed. |
|
@carlisia I'm going to merge this since I know you're busy working on your PR. We can always follow up with more edits as needed. |
Signed-off-by: Nolan Brubaker brubakern@vmware.com