Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restic repository management fixes #1367

Merged
merged 7 commits into from
Apr 17, 2019
Merged

Conversation

skriss
Copy link
Member

@skriss skriss commented Apr 12, 2019

This does not need to make it into the first alpha, so look at other open PRs first.

Currently if, when creating a new restic repo as part of taking a backup, the repo creation fails, Velero waits for an hour before reporting the failure, because it may "eventually" succeed. This is a bad UX, though, and if it failed to create the first time, it won't likely succeed the next time without user intervention. So, I changed it so the backup fails fast if the repo creation fails the first time.

I also lowered the resync interval for the restic repo controller, so repos that become "not ready" are retried more often - makes it more likely to get back to a good state after getting into a bad state.

One or two other small fixes in their own commits.

Testing looks good so far, but would like to do some more.

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss changed the title Restic repo fixes Restic repository management fixes Apr 12, 2019
@skriss skriss requested review from nrb and carlisia April 12, 2019 22:38
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog but 👍

Signed-off-by: Steve Kriss <krisss@vmware.com>
@nrb
Copy link
Contributor

nrb commented Apr 17, 2019

I also lowered the resync interval for the restic repo controller, so repos that become "not ready" are retried more often - makes it more likely to get back to a good state after getting into a bad state.

Is this a separate state from the one mentioned initially (that would take an hour to retry)?

@skriss
Copy link
Member Author

skriss commented Apr 17, 2019

Yeah - existing restic repositories are periodically checked for integrity, and if they fail that for any reason, they'll become NotReady. That's a different case than a new repo that fails to initialize for some reason.

@nrb nrb merged commit 0750b2c into vmware-tanzu:master Apr 17, 2019
@skriss skriss deleted the restic-repo-fixes branch April 17, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants