Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend velero.io to non-namespaced names #1366

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Conversation

nrb
Copy link
Contributor

@nrb nrb commented Apr 12, 2019

Prior to 1.0, user-provided values such as cloud provider names didn't
need to be namespaced. This change allows those values to continue
working without the user editing the fields manually.

Fixes #1363

Signed-off-by: Nolan Brubaker brubakern@vmware.com

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just discovered that restic is now broken too....another patch coming.

@skriss
Copy link
Member

skriss commented Apr 12, 2019

Oh, actually I guess it'll be fixed with this one.

Prior to 1.0, user-provided values such as cloud provider names didn't
need to be namespaced. This change allows those values to continue
working without the user editing the fields manually.

Fixes vmware-tanzu#1363

Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
@skriss skriss merged commit 02cbb77 into vmware-tanzu:master Apr 12, 2019
@nrb nrb deleted the fix-1363 branch April 16, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup locations are invalid after plugin name changes
2 participants