logs commands: validate item exists & is finished processing #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need a changelog? |
skriss
force-pushed
the
logs-cmd-validation
branch
from
265fdb6
to
db8dbfa
Compare
|
Yep - added. |
nrb
reviewed
Apr 1, 2019
changelogs/unreleased/1337-skriss
Outdated
| @@ -0,0 +1 @@ | |||
| velero backup logs & velero restore logs: show helpful error message if item does not exist or is not finished processing | |||
There was a problem hiding this comment.
Might want to clarify the text here a little bit - when I first read the title, I figured we'd be showing nicer errors when the logs file wasn't found.
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
force-pushed
the
logs-cmd-validation
branch
from
db8dbfa
to
1d3d66a
Compare
|
updated |
nrb
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss krisss@vmware.com
Fixes #492
Improves user-friendliness around
velero backup logsandvelero restore logscommands.I also made the structure of the two commands identical for consistency, and opted for the structure of just a single function given how short & simple the logic is.