azure: restore disk with zone

[sylr]

Signed-off-by: Sylvain Rabot sylvain@abstraction.fr

Closes #1159

[skriss]

thanks @sylr! Any chance you were able to test this on a cluster supporting availability zones?

[sylr]

No, I should have created a draft PR. This is not for merge yet unless someone can test it does not break anything/is working.

[skriss]

OK, no problem. Let us know if you're able to test it. I can help out eventually, just need to find the time to figure out how to spin up such a cluster..

[skriss]

I was able to get an Azure AZ-based cluster up and running. This code does not work as-is -- it needs to be rebased (the file has been renamed to volume_snapshotter.go), and also the Zones field is existing just 1, 2, etc., whereas the volumeAZ param passed in is e.g. westus2-2. We'll probably need to parse it ourselves -- I think we can just split on -, and if and only if there's a second part, pass it to Zones.

[skriss]

OK, I did a quick test with modified code that looked like this:

        // TODO add comment
	parts := strings.Split(volumeAZ, "-")
	if len(parts) == 2 {
		disk.Zones = &[]string{parts[1]}
	}

And it worked correctly for both AZ clusters/disks, and non-AZ clusters/disks.

@sylr, if you can update this PR, then we can get it merged and in for v1.0!

[skriss]

pls also add a changelog file, changelogs/unreleased/1298-sylr

[sylr]

@skriss I made it so that it alway take the last item in the array.

[skriss]

LGTM. I was able to successfully test for both AZ disks and non-AZ disks. Thanks @sylr!

[skriss]

@nrb or @carlisia pls review/merge when ready.

[carlisia]

👍