-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup-version file in backup tarball #1117
Conversation
16e6f68
to
6be86b2
Compare
@ncdc PTAL |
Now that I'm thinking about this PR - we will now store some metadata as objects directly in object storage (e.g. |
@skriss That's a good question on the duplication. My current thought is that the backup version should be in the tarball, so that it could be processed if moved around. Information that's useful for periodic checks should be outside the tarball, though, since we don't want to download and extract them all on a regular basis. |
I remember during the original discussion we wanted to intentionally keep |
So where did we land on this? There was also some conversation in #ark-dr that I wanted to echo here. I am going to update this so that we will have a |
Nolan is correct - we want the 👍 to |
SGTM for now, though we probably need more thinking/work about how a tarball without an |
I guess it probably can't be 100% portable, since we have other information in the bucket (snapshot details, logs) |
this lgtm pending moving the file into a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This is ready to merge if everyone is happy with it. |
Signed-off-by: Wayne Witzel III <wwitzel3@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this trend of moving logic and data to outside of controllers. This lgtm. 👍
@ncdc I think we were just waiting for your approval here since you had a comment - merge if happy :) |
Didn't realize y'all were waiting on me! |
Closes #134