testifylint: enable and fix go-require rule

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

.github/workflows/pr-linter-check.yml

@@ -15,5 +15,5 @@ jobs:
       - name: Linter check
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.57.2
+          version: v1.61.0
           args: --verbose

.golangci.yaml

@@ -238,7 +238,6 @@ linters-settings:
   testifylint:
       # TODO: enable them all
       disable:
-        - go-require
         - float-compare
         - require-error
       enable-all: true

hack/build-image/Dockerfile

@@ -94,7 +94,7 @@ RUN ARCH=$(go env GOARCH) && \
     chmod +x /usr/bin/goreleaser
 
 # get golangci-lint
-RUN curl -sSfL https://github.com/raw/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.57.2
+RUN curl -sSfL https://github.com/raw/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.61.0
 
 # install kubectl
 RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/$(go env GOARCH)/kubectl

pkg/backup/actions/csi/pvc_action_test.go

@@ -27,6 +27,7 @@ import (
 	snapshotv1api "github.com/kubernetes-csi/external-snapshotter/client/v7/apis/volumesnapshot/v1"
 	v1 "github.com/kubernetes-csi/external-snapshotter/client/v7/apis/volumesnapshot/v1"
 	"github.com/sirupsen/logrus"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	corev1 "k8s.io/api/core/v1"
 	storagev1 "k8s.io/api/storage/v1"
@@ -176,28 +177,28 @@ func TestExecute(t *testing.T) {
 					err := wait.PollUntilContextTimeout(context.Background(), 1*time.Second, 10*time.Second, true, func(ctx context.Context) (bool, error) {
 						err = pvcBIA.crClient.List(ctx, &vsList, &crclient.ListOptions{Namespace: tc.pvc.Namespace})
 
-						require.NoError(t, err)
+						assert.NoError(t, err)
 						if err != nil || len(vsList.Items) == 0 {
 							//lint:ignore nilerr reason
 							return false, nil // ignore
 						}
 						return true, nil
 					})
 
-					require.NoError(t, err)
+					assert.NoError(t, err)
 					vscName := "testVSC"
 					readyToUse := true
 					vsList.Items[0].Status = &v1.VolumeSnapshotStatus{
 						BoundVolumeSnapshotContentName: &vscName,
 						ReadyToUse:                     &readyToUse,
 					}
 					err = pvcBIA.crClient.Update(context.Background(), &vsList.Items[0])
-					require.NoError(t, err)
+					assert.NoError(t, err)
 
 					handleName := "testHandle"
 					vsc := builder.ForVolumeSnapshotContent("testVSC").Status(&snapshotv1api.VolumeSnapshotContentStatus{SnapshotHandle: &handleName}).Result()
 					err = pvcBIA.crClient.Create(context.Background(), vsc)
-					require.NoError(t, err)
+					assert.NoError(t, err)
 				}()
 			}
 

pkg/cmd/cli/backup/logs_test.go

@@ -136,7 +136,7 @@ func TestNewLogsCommand(t *testing.T) {
 		done := make(chan bool)
 		go func() {
 			err = l.Run(c, f)
-			require.Error(t, err)
+			assert.Error(t, err)
 		}()
 
 		select {