Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc that WaitForFirstConsumer is not supported at restore time #567

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add doc that WaitForFirstConsumer is not supported at restore time #567

merged 1 commit into from
Feb 28, 2024

Conversation

xing-yang
Copy link
Contributor

What this PR does / why we need it:
At restore time, StorageClass with WaitForFirstConsumer VolumeBindingMode is not supported. Only StorageClass with Immediate VolumeBindingMode is supported at restore time. Add documentation for this.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
When StorageClass with WaitForFirstConsumer VolumeBindingMode was used at restore time, we got the following "PVC did not become Bound" error.

error preparing persistentvolumeclaims/ivt/nginx-pvc: rpc error: code = Unknown desc = Failed to create a CloneFromSnapshot CR: Phase=Failed, err=cloneFromSnapshot: Failed at calling SnapshotManager CreateVolumeFromSnapshotWithMetadata with peId pvc:ivt/nginx-pvc, err: PVC "nginx-pvc" did not become Bound: PersistentVolumeClaims [nginx-pvc] not all in phase Bound within 3m0s
Error creating volume from metadata
github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotmgr.(*SnapshotManager).CreateVolumeFromSnapshotWithMetadata
  /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/snapshotmgr/snapshot_manager.go:779
github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver.(*backupDriverController).cloneFromSnapshot
  /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver/backup_driver_controller.go:311
github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver.(*backupDriverController).syncCloneFromSnapshotByKey
  /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver/backup_driver_controller_base.go:617
github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver.(*backupDriverController).cloneFromSnapshotWorker
  /go/src/github.com/vmware-tanzu/velero-plugin-for-vsphere/pkg/backupdriver/backup_driver_controller_base.go:562
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
  /go/pkg/mod/k8s.io/apimachinery@v0.24.2/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
  /go/pkg/mod/k8s.io/apimachinery@v0.24.2/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
  /go/pkg/mod/k8s.io/apimachinery@v0.24.2/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.Until
  /go/pkg/mod/k8s.io/apimachinery@v0.24.2/pkg/util/wait/wait.go:90
runtime.goexit
  /usr/local/go/src/runtime/asm_amd64.s:1571

Does this PR introduce a user-facing change?:

NONE

@xing-yang
Add doc that wffc is not supported
59df50a 
Signed-off-by: xing-yang <xingyang105@gmail.com>
@xing-yang xing-yang merged commit 58768bb into vmware-tanzu:main Feb 28, 2024
2 checks passed
lipingxue pushed a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Mar 11, 2024
@xing-yang @lipingxue
Add doc that wffc is not supported (vmware-tanzu#567)
5e1f755 
Signed-off-by: xing-yang <xingyang105@gmail.com>
@lipingxue lipingxue mentioned this pull request Mar 11, 2024
Merged
lipingxue pushed a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Mar 11, 2024
@xing-yang @lipingxue
Add doc that wffc is not supported (vmware-tanzu#567)
71a3484 
Signed-off-by: xing-yang <xingyang105@gmail.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue added a commit that referenced this pull request Mar 11, 2024
@lipingxue @dependabot
@varunsrinivasan2 @xing-yang @deepakkinni
Cherry-pick changes to release-1.5 branch. (#570)
0b9a8de 
* Update support matrix for Vanilla, WCP and GC. (#559)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Document change to update known issue. (#560)

* Document change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Remove files that are not needed for this change.

Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#562)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update document. (#566)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Modify parsing behavior of login credentials to handle Go escape characters (#564)

* Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

Create common config and new function to parse config data

* Always populate "port" key of parameters map after setting default VC port if config port value is empty

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Clean up test logging and unit tests

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Keep only necessary config values

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Refactor ParseConfig to return error for sanitized error handling

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

---------

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Only skip PVC creation if --namespace-mapping flag is not used (#565)

* Only skip PVC creation if --namespace-mapping flag is not used

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

* Refactor SkipPVCCreation function signature to add target namespace as a parameter

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>

---------

Signed-off-by: Varun Srinivasan <varuns6@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Add doc that wffc is not supported (#567)

Signed-off-by: xing-yang <xingyang105@gmail.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Fail the Restore if the StorageClass is associated with WaitForFirstConsumer volumeBindingMode (#568)

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Co-authored-by: Deepak Kinni <dkinni@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Varun Srinivasan <varuns6@vmware.com>
Signed-off-by: xing-yang <xingyang105@gmail.com>
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Varun Srinivasan <varun.srinivasan@broadcom.com>
Co-authored-by: Xing Yang <xingyang105@gmail.com>
Co-authored-by: Deepak Kinni <deepak.kinni@broadcom.com>
Co-authored-by: Deepak Kinni <dkinni@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipingxue lipingxue lipingxue left review comments

@deepakkinni deepakkinni deepakkinni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xing-yang @deepakkinni @lipingxue