Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to vSphere documentation in supervisor-datamgr.md file #536

Merged
merged 2 commits into from
May 26, 2023

Conversation

lipingxue
Copy link
Collaborator

What this PR does / why we need it:
This change is to update link to vSphere documentation in supervisor-datamgr.md file. The old link does not work.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Liping Xue <lipingx@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>
@svcbot-qecnsdp
Copy link

Congratulations !!

All the pre-check tests passed
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/815/

@svcbot-qecnsdp
Copy link

Congratulations !!

All the pre-check tests passed
https://container-dp.svc.eng.vmware.com/job/CNSDP-CI/816/

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Data Manager Virtual Machine install" section, can you also update line 38 to the general releases page:
https://github.com/vmware-tanzu/velero-plugin-for-vsphere/releases
Currently it points to an older 1.1.0 ova of the data manager.

@xing-yang
Copy link
Contributor

@lipingxue I'm going to merge this. Please submit a separate PR to address my comment. Thanks.

Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xing-yang xing-yang merged commit 2937fe0 into vmware-tanzu:main May 26, 2023
lipingxue added a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Jun 27, 2023
…mware-tanzu#536)

* Update vSphere doc link in supervisor-datamgr.md.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.
Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue added a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Oct 26, 2023
…mware-tanzu#536)

* Update vSphere doc link in supervisor-datamgr.md.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.
Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue added a commit to lipingxue/velero-plugin-for-vsphere that referenced this pull request Oct 27, 2023
…mware-tanzu#536)

* Update vSphere doc link in supervisor-datamgr.md.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.
Signed-off-by: Liping Xue <lipingx@vmware.com>
lipingxue added a commit that referenced this pull request Oct 27, 2023
* Update script.
Signed-off-by: Liping Xue <lipingx@vmware.com>

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Add warning message in compatibility table. (#534)

* Add warning message in compatibility table.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update link to vSphere documentation in supervisor-datamgr.md file (#536)

* Update vSphere doc link in supervisor-datamgr.md.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Address comment from Xing.
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update link to data manager ova. (#537)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Fix upload retry. (#532)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update support matrix for Vanilla, WCP and GC. (#538)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update support matrix for WCP.
Signed-off-by: Liping Xue lipingx@vmware.com

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update Snapshot and upload CRD status in doc. (#545)

Signed-off-by: Liping Xue lipingx@vmware.com

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Add document on Deploy Velero in Supervisor Cluster with Images from Private Registry. (#543)

Signed-off-by: Liping Xue lipingx@vmware.com

Signed-off-by: Liping Xue lipingx@vmware.com
Signed-off-by: Liping Xue <lipingx@vmware.com>

* Update support matrix for Vanilla. (#548)

Signed-off-by: Liping Xue <lipingx@vmware.com>

* Bump the golang.org/x/net version to v0.17.0 to address CVEs. (#552)

Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Liping Xue <lipingx@vmware.com>

---------

Signed-off-by: Liping Xue <lipingx@vmware.com>
Signed-off-by: Liping Xue lipingx@vmware.com
Signed-off-by: Xun Jiang <jxun@vmware.com>
Co-authored-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants