-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
Hi @akutz! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
Hi @jmoroski / @vijaykatam / @ankeesler, One odd thing I noticed is the Pinniped config-controller does not reference the parent module by relative path but by a pinned version. Is this on purpose? Ex.
This is anachronistic to how other modules in this repository reference the parent module, ex. Line 6 in ba2b0e1
|
7b5402b
to
ded723d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change. I think pinniped could refer to relative path as well. Will ping @ankeesler
Thanks. I already pinged him in the comment up above, but this way he'll definitely see it. |
This patch adds support for treating the API packages for CNI and CPI as distinct Go modules so remote repositories can import these modules without inheriting the entire tanzu-framework dependency graph.
ded723d
to
ec7b65a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
FWIW, we resolved offline to separate the changes. |
LGTM |
What this PR does / why we need it
This patch adds support for treating the API packages for CNI and CPI as distinct Go modules so remote repositories can import these modules without inheriting the entire tanzu-framework dependency graph.
Which issue(s) this PR fixes
Fixes
NA
Describe testing done for PR
I built all of the project's Go modules:
Release note
PR Checklist
Additional information
cc @vijaykatam @sidharthsurana @jmoroski
Special notes for your reviewer