upgrade github.com/go-jose/go-jose and github.com/coreos/go-oidc #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
+ Coverage 30.68% 30.70% +0.02%
==========================================
Files 365 365
Lines 60617 60616 -1
==========================================
+ Hits 18600 18615 +15
+ Misses 41481 41466 -15
+ Partials 536 535 -1 ☔ View full report in Codecov by Sentry. |
cfryanr
force-pushed
the
upgrade_jose_and_coreosoidc
branch
from
10fe065
to
a99aa6e
Compare
Also standardize some related imports and fix some whitespace in a test
cfryanr
force-pushed
the
upgrade_jose_and_coreosoidc
branch
from
a99aa6e
to
0380a9c
Compare
ashish-amarnath
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also standardize some related imports and fix some whitespace in a test.
There was one line of code where we still need to use
github.com/go-jose/go-jose/v3, so I could not entirely remove it as a direct dependency yet. But it is only used on that one line of code now. All other code usesgithub.com/go-jose/go-jose/v4.Upgrading
github.com/coreos/go-oidc/v3to the latest version forced a change to our production code injwtcachefiller.go(see diffs) because that library did not like our unsigned JWT anymore. I changed it to be a signed JWT to make the library happy. Our functionality should be unchanged, as proved by the unit tests for that file.Release note:
None, Golang dependency upgrade only.