Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing Tanzu Builder and use if there #109

Conversation

codegold79
Copy link
Contributor

@codegold79 codegold79 commented Jun 30, 2023

Description

Although it's not the recommended way to download and use Tanzu CLI Plugin Builder, provide a direct way to obtain the builder binary and use it. Bypass using Tanzu CLI altogether.

Fixes #108

Change Details

Check all that apply:

  • New feature
  • Bug fix
  • Non-code change
  • Non-breaking change
  • Breaking change
  • Requires a documentation change

Release Note

Allow for existing Tanzu Builder instead of installing it via Tanzu CLI

How Has This Been Tested?

Describe any testing done to verify changes. Provide enough detail that tests can be reproduced.

I built and published the codegen and featuregate plugins in the Tanzu Framework repository on my local machine.

Checklist:

  • My code follows the Contribution and Style guidelines of this project
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have added test details that prove my fix is effective or that my feature works

Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79 codegold79 added the kind/enhancement Improvement or refactoring of existing feature label Jun 30, 2023
@codegold79 codegold79 self-assigned this Jun 30, 2023
@codegold79 codegold79 marked this pull request as ready for review July 1, 2023 16:28
Copy link
Contributor

@avi-08 avi-08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

templates/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@yharish991 yharish991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: F. Gold <fgold@vmware.com>
@codegold79
Copy link
Contributor Author

@yharish991, @avi-08 , I had to re-request review because I added a commit that put the tanzu-builder into a new directory, tanzu-cli.

@codegold79 codegold79 merged commit 09c18a4 into vmware-tanzu:main Jul 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required kind/enhancement Improvement or refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for existing Tanzu Builder and use if there
4 participants