This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Action to update generated components with cron job #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Rathke <liam.rathke@gmail.com>
| - name: Install NodeJS | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: 14 |
There was a problem hiding this comment.
It's safe to bump to 16 here since LTS is coming in a month and we've moved upstream CI already
signed-off-by: Liam Rathke <lrathke@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Action that should run once every 24 hours; it will pull
vmware-tanzu/octant, run the command to automatically generate TypeScript components, and if the generated components differ from those previously generated, it will commit the newly regenerated components to this repo.Relevant issues:
Testing changes:
This action is somewhat difficult to test; I ran into issues locally when trying to run the action within act, and eventually gave up and just tested the action on my fork.
If testing on a fork, please replace
vmware-tanzu/octanton line 23 inupdate-components.yamlwith a path to your Octant fork; changing the trigger from a cron job to a more replicable event (e.g. push) will be useful too.