This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Summary sections can be updated #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Summary component to allow its summary sections to be updated. To update a section, add a new item with an existing name. This change will allow plugins to update existing config and status items in the object summary. This is useful for converting text components to link components. Signed-off-by: bryanl <bryanliles@gmail.com>
bryanl
force-pushed
the
update-summary-sections
branch
from
536ea5e
to
5b39e44
Compare
|
@vmware-tanzu/octant-reviewers ping! |
|
I worried about what happens when every plugin wants to write their own custom message to a well defined section, it is basically what ever plugin gets there last wins. |
@wwitzel3 Yes. The last one written wins. There's not an easy way to stop it from happening other than public shaming. |
wwitzel3
approved these changes
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Summary component to allow its summary sections to
be updated. To update a section, add a new item with an
existing name.
This change will allow plugins to update existing config and
status items in the object summary. This is useful for
converting text components to link components.
Fixes: #717
Signed-off-by: bryanl bryanliles@gmail.com