Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

allow button group to be unmarshaled from JSON #647

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

wwitzel3
Copy link
Contributor

@wwitzel3 wwitzel3 commented Feb 8, 2020

Signed-off-by: Wayne Witzel III wayne@riotousliving.com

What this PR does / why we need it:
Allows ButtonGroup to be used by Plugins.

Which issue(s) this PR fixes

Special notes for your reviewer: Example plugin https://github.com/wwitzel3/octant-actions-plugin

Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
@wwitzel3 wwitzel3 requested a review from a team February 8, 2020 17:05
@wwitzel3 wwitzel3 self-assigned this Feb 8, 2020
@wwitzel3
Copy link
Contributor Author

wwitzel3 commented Feb 8, 2020

I know you were interested in this functionality @imjasonh

@GuessWhoSamFoo GuessWhoSamFoo mentioned this pull request Feb 8, 2020
11 tasks
Copy link
Contributor

@GuessWhoSamFoo GuessWhoSamFoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

image

@GuessWhoSamFoo GuessWhoSamFoo merged commit f17f454 into vmware-archive:master Feb 9, 2020
@wwitzel3 wwitzel3 deleted the issue-646-button branch March 13, 2021 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants