-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Unpin outlines #4558
Conversation
I think the reason for the pin is exactly the error here in test...
|
I have removed the The thing is that the underlying implementation is the same as with the I'm afraid we'll have to wait for this issue to be fixed. I'm inclined to close this PR... |
There are several of us who are not using the |
It's up for the maintainers of vLLM to decide what exactly is to be done here. We can:
|
This is recommended by the outlines maintainers for us to maintain the logits processor interface and keep the interface between libraries at the FSM/Guide level. |
Hmmm. It's generating '3.5.0.10653515246264', maybe tune the temperature or prompting? |
@simon-mo that’s the regression described in outlines-dev/outlines#856. This is a bug in outlines. We can either disable the test, or wait for the fix, as I listed above. |
I have identified the source of the problem in outlines and am waiting for a PR (outlines-dev/outlines#874) to get merged with the fix. Once this is done, we can move on with the migration to the I'll close this PR in favor of #4109. |
I merged the PR that fixes outlines-dev/outlines#874. Indeed @saattrupdan I think it makes more sense to have the processors in vLLM so Outlines is not concerned with details of the implementation and can focus on structured generation alone. |
Ah, so the plan is to remove the vLLM integration from the outlines code, and instead ask users to use the one in vLLM? |
Unpin the outlines dependency.
FIX #4153
Since work on #4109 will take a bit longer...
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!