Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure seq is always incremented on every operation in a tx and always only by 1 #238

Merged
merged 3 commits into from
Jun 18, 2023
Merged

Ensure seq is always incremented on every operation in a tx and always only by 1 #238

merged 3 commits into from
Jun 18, 2023

Commits on Jun 18, 2023

  1. ensure seq moves up only by 1 per operation

    @tantaman
    tantaman committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    0bd0aca View commit details
    Browse the repository at this point in the history

  2. tests for seq case

    @tantaman
    tantaman committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    c7fd9eb View commit details
    Browse the repository at this point in the history

  3. subtract 1 from on conflict clauses that set the seq 

    The `select` portion is _always_ run.

The `on conflict` clause might be run. Since the select is always run (conditional on the where clause matching) then the seq is already incremented. The conflict clause needs to get the previous seq number rather than current.
    @tantaman
    tantaman committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    07dce43 View commit details
    Browse the repository at this point in the history