This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Entries fetched with db.GetOrInsert and written with db.Put will now correctly flush the memcache #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly flush the memcache This bug can cause consinstency issues with the datastore if an entry is fetched with GetOrInsert and then later modified and written back to the datastore with db.Put. In this case, the old version of this entry is not beeing removed from the memcache and thus returned in subsequent db.Get() calls. This does not happen if the entry is exclusivly read with GetOrInsert becorse GetOrInsert will run in a transaction (in which the memcache is never accessed).
tsteinruecken
requested review from
skoegl,
sveneberth,
AchimSchumacher,
xnopasaranx,
phorward,
akelch,
haxxoremmi and
ArneGudermann
xnopasaranx
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug can cause consinstency issues with the datastore if an entry is fetched with
GetOrInsert and then later modified and written back to the datastore with db.Put.
In this case, the old version of this entry is not beeing removed from the memcache
and thus returned in subsequent db.Get() calls. This does not happen if the entry is exclusivly read
with GetOrInsert becorse GetOrInsert will run in a transaction (in which the memcache is never accessed).