This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Allow empty date setting to dateBone #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a date back to empty is not possible using fromClient right now: Empty string is converted to None, and None is not allowed by super-call to baseBone.isInvalid() as valid value. So this might fix the problem and integrates with [#32](viur-framework/viur-vi#32) in vi.
skoegl
previously approved these changes
Apr 15, 2019
sveneberth
approved these changes
Apr 17, 2019
sveneberth
previously requested changes
Apr 17, 2019
|
Not sure if this will break anything (the correct way would be to fix isInvalid and the correct handling of errors in non-required bones). If you tested it we can merge it and fix it correctly in Server 3.0 |
|
We can do it using |
|
I don't care, if it does not break anything (i don't think it will but everyone should have a look on this). As said this will be fixed correctly in 3.0, this has to work only for a year or two :) |
bones/dateBone.py
Outdated
| @@ -158,7 +158,7 @@ def fromClient( self,valuesCache, name, data ): | |||
| else: | |||
| err = self.isInvalid(value) | |||
| if not err: | |||
There was a problem hiding this comment.
After further investigation i would recommend reverting these two changes and change this line to "if not err or value is None". This should do the trick and be more consistent with other bones
tsteinruecken
approved these changes
May 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a date back to empty is not possible using fromClient right now: Empty string is converted to None, and None is not allowed by super-call to baseBone.isInvalid() as valid value. So this might fix the problem and integrates with #32 in vi.