This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Unwrap the first dictionary access in fileBone:unserialize #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteinruecken
requested review from
skoegl,
sveneberth,
AchimSchumacher,
xnopasaranx,
phorward,
akelch and
ArneGudermann
sveneberth
reviewed
Mar 28, 2019
|
Hm.. I now unwrapped the ones in the lower blocks also. We could of course unwrap them in the upper block also, but we would trade 3 dictionary accesses for 1 dictionary access + one variable allocation. I doubt that this will be significantly faster... |
sveneberth
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #126