Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Fix skeleton.toDB.txnUpdate #111

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Fix skeleton.toDB.txnUpdate #111

merged 4 commits into from
Mar 28, 2019

Conversation

phorward
Copy link
Member

This is a pull-request as proposal to resolve #110 and reduce the number of loops inside the function.

@phorward phorward changed the base branch from master to develop November 22, 2018 10:39
@tsteinruecken
Copy link
Contributor

Condensing the Loop looks good to me (through i'll need to check if this would cause any side-effects).
But we can't call serialize only if the key is present in valuesCache, some bones (like randomSliceBone) have no such value (especially during add) - but need to be serialized anyway.

@phorward
Call serialize() always as proposed in the comments
07610b4 
Also corrected all "uniqe" to "unique"
@phorward
Copy link
Member Author

Hi, I've pushed a corrected version that calls bone.serialize() always now.
I did a test run with this skeleton.py in a huger project without any problems.

@sveneberth sveneberth added this to the v2.4 milestone Feb 27, 2019
tsteinruecken
tsteinruecken reviewed Mar 25, 2019
View reviewed changes
skeleton.py Outdated Show resolved Hide resolved
tsteinruecken
tsteinruecken reviewed Mar 25, 2019
View reviewed changes
skeleton.py Outdated Show resolved Hide resolved
tsteinruecken
tsteinruecken suggested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@tsteinruecken tsteinruecken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safe to merge after the two issues had been addressed

@tsteinruecken tsteinruecken merged commit 1c00c58 into develop Mar 28, 2019
@tsteinruecken tsteinruecken deleted the fix_Skeleton.toDB.txnUpdate branch March 28, 2019 12:46
@sveneberth sveneberth linked an issue Jun 10, 2020 that may be closed by this pull request
Exception raised in several bones when working with sub-skeletons #110
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tsteinruecken tsteinruecken tsteinruecken approved these changes

Assignees
No one assigned
Labels
discussion proposal v2.4
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Exception raised in several bones when working with sub-skeletons
3 participants
@phorward @tsteinruecken @sveneberth