Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace strip-ansi with stripVTControlCharacters from node:util #6608

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Oct 1, 2024

Description

"engines": {
"node": "^18.0.0 || >=20.0.0"
},

ari ~/Git/vitest (chore/strip-ansi) $ node
Welcome to Node.js v18.0.0.
Type ".help" for more information.
> util.stripVTControlCharacters
[Function: stripVTControlCharacters]
>

ari ~/Git/vitest (chore/strip-ansi) $ node
Welcome to Node.js v20.0.0.
Type ".help" for more information.
> util.stripVTControlCharacters
[Function: stripVTControlCharacters]
> 

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio changed the title chore(deps): replace strip-ansi with stripVTControlCharacters fro… chore(deps): replace strip-ansi with stripVTControlCharacters from node:util Oct 1, 2024
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ab730b7
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66fc47a3cee72200082e6d8b
😎 Deploy Preview https://deploy-preview-6608--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e0f85c
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66fce7214de7770009c0c7a9
😎 Deploy Preview https://deploy-preview-6608--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio changed the title chore(deps): replace strip-ansi with stripVTControlCharacters from node:util refactor: replace strip-ansi with stripVTControlCharacters from node:util Oct 1, 2024
@AriPerkkio AriPerkkio marked this pull request as ready for review October 2, 2024 06:49
@sheremet-va sheremet-va merged commit 5f75790 into vitest-dev:main Oct 2, 2024
17 checks passed
@AriPerkkio AriPerkkio deleted the chore/strip-ansi branch October 2, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants