Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop default in TypeScript files #2610

Closed
6 tasks done
sheremet-va opened this issue Jan 4, 2023 · 1 comment · Fixed by #2682
Closed
6 tasks done

Interop default in TypeScript files #2610

sheremet-va opened this issue Jan 4, 2023 · 1 comment · Fixed by #2682
Labels
enhancement New feature or request

Comments

@sheremet-va
Copy link
Member

Describe the bug

In the latest version we disabled dips.interopDefault for node environments, because we assume users are using Node ESM, but TypeScript can be bundled either way and doesn't actually follow ESM spec.

Because of this we should interop default, if code has tsconfig that doesn't bundle ESM.

Reproduction

https://github.com/c100k/vitest-0.26.x-breaking-changes

System Info

Any

Used Package Manager

npm

Validations

@sheremet-va sheremet-va added the enhancement New feature or request label Jan 4, 2023
@sheremet-va
Copy link
Member Author

Looking at the reaction, I think ecosystem is not ready for this change yet. We should revert interopDefault behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant