fix(coverage): pass thresholds errors to stderr of startVitest() (#…

…5954)
vitest-dev · Jun 23, 2024 · 7080513 · 7080513
1 parent e9ddf9c
commit 7080513
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/packages/coverage-istanbul/src/provider.ts b/packages/coverage-istanbul/src/provider.ts
@@ -336,6 +336,7 @@ export class IstanbulCoverageProvider
       this.checkThresholds({
         thresholds: resolvedThresholds,
         perFile: this.options.thresholds.perFile,
+        onError: error => this.ctx.logger.error(error),
       })
 
       if (this.options.thresholds.autoUpdate && allTestsRun) {

diff --git a/packages/coverage-v8/src/provider.ts b/packages/coverage-v8/src/provider.ts
@@ -324,6 +324,7 @@ export class V8CoverageProvider
       this.checkThresholds({
         thresholds: resolvedThresholds,
         perFile: this.options.thresholds.perFile,
+        onError: error => this.ctx.logger.error(error),
       })
 
       if (this.options.thresholds.autoUpdate && allTestsRun) {

diff --git a/packages/vitest/src/utils/coverage.ts b/packages/vitest/src/utils/coverage.ts
@@ -95,9 +95,11 @@ export class BaseCoverageProvider {
   checkThresholds({
     thresholds: allThresholds,
     perFile,
+    onError,
   }: {
     thresholds: ResolvedThreshold[]
     perFile?: boolean
+    onError: (error: string) => void
   }) {
     for (const { coverageMap, thresholds, name } of allThresholds) {
       if (
@@ -154,7 +156,7 @@ export class BaseCoverageProvider {
                 )}`
               }
 
-              console.error(errorMessage)
+              onError(errorMessage)
             }
           }
         }