Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): restore usage of extension instead of id #5761

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

frandiox
Copy link
Contributor

Description

The id parameter could contain a querystring so the extension checks should be done using the extension variable. This was the case until it was reverted in #5255 but probably not on purpose (@aleclarson is this correct?)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@frandiox frandiox changed the title fix: restore usage of extension instead of id fix(plugin-react): restore usage of extension instead of id Nov 19, 2021
@Shinigami92
Copy link
Member

Is this a bug fix or an optimization? 🤔

@patak-dev
Copy link
Member

Any chance to add a test for this one?

@aleclarson
Copy link
Member

Sorry, that slipped by when rebasing an older PR. 😬

Perhaps a test could be added later, but I don't expect this regression to happen again.

@antfu antfu merged commit 59471b1 into vitejs:main Nov 19, 2021
@IanVS
Copy link
Contributor

IanVS commented Nov 19, 2021

Hah, I just spent most of the day figuring out what was going on in my tests, and was about to submit this exact PR. 😆 Thanks for being a step ahead of me, @frandiox. This should also close #5752.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants