Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support css preprocessor @import #313

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

underfin
Copy link
Member

close #9

src/node/utils/cssUtils.ts Outdated Show resolved Hide resolved
src/node/utils/cssUtils.ts Outdated Show resolved Hide resolved
src/node/utils/cssUtils.ts Outdated Show resolved Hide resolved
src/node/server/serverPluginVue.ts Outdated Show resolved Hide resolved
src/node/server/serverPluginCss.ts Outdated Show resolved Hide resolved
src/node/utils/cssUtils.ts Outdated Show resolved Hide resolved
@underfin
Copy link
Member Author

underfin commented Jun 1, 2020

Because postcss-import only support ananlysis plain css import syntax.So we must use preprocessor api to get deps relation.

@Justineo
Copy link
Contributor

Justineo commented Jun 1, 2020

Inlining imported content isn't precise enough. (eg. Less supports conditional imports.)

We may still have to retrieve dependencies with preprocessors' own render APIs (as implemented in corresponding webpack loaders).

@underfin
Copy link
Member Author

underfin commented Jun 1, 2020

vuejs/core#1278.
Please check it first.Less export has an issues which not export dependencies correctly.I take a issue to less repo.

@csr632
Copy link
Member

csr632 commented Jul 16, 2020

Can we move this forward? How can I help? This issue is blocking my sass usecase.
Sorry for bothering!
@yyx990803

@yyx990803 yyx990803 merged commit cc1e8e8 into vitejs:master Jul 16, 2020
@underfin underfin deleted the css-preprocessor-hmr branch July 17, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR when using imported sass files
4 participants