Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): (backport #18150) fix source map remapping with multiple sources #18204

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(ssr): (backport #18150) fix source map remapping with multiple sources #18204

merged 1 commit into from
Sep 30, 2024
+61 −10

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Sep 26, 2024 •
edited
Loading

Description

Backporting #18150 to unblock debugger issues on Vitest vitest-dev/vitest#6526.
It doesn't need to be released asap but it would be great to have if there's a chance for next batch of v5 patch.

@hi-ogawa @AriPerkkio
fix(ssr): (backport vitejs#18150) fix source map remapping with multi…
e47b220 
…ple sources

Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review September 28, 2024 01:03
@sapphi-red
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci

This comment was marked as outdated.

Sign in to view
@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on e47b220: Open

suite result latest scheduled
histoire ✅ success ❌ failure
remix ✅ success ❌ failure
sveltekit ❌ failure ✅ success
vike ✅ success ❌ failure
vuepress ❌ failure ✅ success

✅ analogjs, astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest

@hi-ogawa
Copy link
Collaborator Author

hi-ogawa commented Sep 30, 2024 •
edited
Loading

Vuepress fail says playwright installation issue https://github.com/vitejs/vite-ecosystem-ci/actions/runs/11098468509/job/30834087016#step:8:1566

Sveltekit fail is something I saw before in #18152 (comment), so probably flaky https://github.com/vitejs/vite-ecosystem-ci/actions/runs/11098468509/job/30834085391#step:8:2377

@hi-ogawa

This comment was marked as outdated.

Sign in to view
@vite-ecosystem-ci

This comment was marked as outdated.

Sign in to view
@sapphi-red
Copy link
Member

/ecosystem-ci run sveltekit

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on e47b220: Open

✅ sveltekit

@sapphi-red
Copy link
Member

/ecosystem-ci run vuepress

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on e47b220: Open

✅ vuepress

sapphi-red
sapphi-red approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, everything passed 👍

@sapphi-red sapphi-red merged commit 262a879 into vitejs:v5 Sep 30, 2024
11 checks passed
@hi-ogawa hi-ogawa deleted the fix-v5-backport-18159 branch September 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hi-ogawa @sapphi-red