Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): explicitly mention how to install vite (#16583) #17404

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

hchiam
Copy link
Contributor

@hchiam hchiam commented Jun 6, 2024

Description

fixes #16583

Copy link

stackblitz bot commented Jun 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hchiam
Copy link
Contributor Author

hchiam commented Jun 6, 2024

open to feedback/input
#16583 (comment)

@bluwy
Copy link
Member

bluwy commented Jun 6, 2024

I think it may be worth adding a new section called "Manual installation" after the "Community templates" section. Besides mentioning how to install Vite, I think it should also guide creating a very simple index.html file, and it should be enough.

We also shouldn't mention installing vite globally as explained at #16583 (comment). Thanks for kicking this off!

Copy link
Contributor Author

@hchiam hchiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made edits and fixed the commit message text. @bluwy let me know if this is closer to what you had in mind

@bluwy
Copy link
Member

bluwy commented Jun 10, 2024

I've committed some updates, and I think it should do now 👍

Copy link
Contributor Author

@hchiam hchiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @bluwy!

@hchiam hchiam mentioned this pull request Jun 13, 2024
4 tasks
docs/guide/index.md Outdated Show resolved Hide resolved
@patak-dev patak-dev enabled auto-merge (squash) June 14, 2024 06:46
@patak-dev patak-dev merged commit af194e2 into vitejs:main Jun 14, 2024
10 of 11 checks passed
@hchiam hchiam deleted the patch-1 branch June 14, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install options/guide
3 participants