Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent unhandledRejection if --open fails #16726

Merged
merged 3 commits into from
May 30, 2024

Conversation

gtm-nayan
Copy link
Contributor

Description

Apparently the catch doesn't work unless you pass in wait: true in options for open, but doing so seems to do some other stuff as well which may not be desired so did it this way

Copy link

stackblitz bot commented May 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 27, 2024
@patak-dev patak-dev merged commit 1f60647 into vitejs:main May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants