fix(optimize-deps): don't externalize JS files imported with asset extensions #16242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sapphi-red
added
p3-minor-bug
sapphi-red
reviewed
Mar 24, 2024
sure, I'll add a test case |
|
@sapphi-red hi, I have submitted the test code, but how does the Actions check failing |
|
I guess you forgot to run |
sapphi-red
changed the title
sapphi-red
approved these changes
Mar 27, 2024
bluwy
reviewed
May 18, 2024
Comment on lines
157
to
+159
| if (kind === 'require-call') { | ||
| // #16116 fix: Import the module.scss path, which is actually module.scss.js | ||
| if (resolved.endsWith('.js')) { |
There was a problem hiding this comment.
Is there a reason we only check this in require-call only? Wouldn't this help for imports too?
There was a problem hiding this comment.
I think the reason is because we don't support import without extensions in dependencies. But I've noticed that there's a case like import 'normalize.css'.
There was a problem hiding this comment.
Ah right, you have to specify the full path with imports. Let's try this then.
bluwy
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #16116 importing a CommonJS module installed from NPM. The modue contains files with filenames like PeoplePicker.scss.js. These are JavaScript files, obviously, but the filename contains scss.
What is the purpose of this pull request?