-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: omit 'plugins' since it has no effect #13879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
gulewei
changed the title
types: omit 'plugins' since it has no effect
fix: omit 'plugins' since it has no effect
Jul 17, 2023
I think we could do this change in Vite 5, to avoid messing with the types in a patch. |
patak-dev
added
the
p3-minor-bug
An edge case that only affects very specific usage (priority)
label
Jul 17, 2023
patak-dev
approved these changes
Jul 17, 2023
However, it seems doesn't break anything:
type T1 = UserConfig;
type T2 = Omit<UserConfig, 'plugins'>;
type R1 = (() => T1 | Promise<T1>) extends (() => T2 | Promise<T2>) ? true : false; // true
type R2 = (() => T2 | Promise<T2>) extends (() => T1 | Promise<T1>) ? true : false; // true |
Hey @gulewei, I already reviewed this PR. We should let others check it out and merge it. |
bluwy
approved these changes
Sep 14, 2023
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since it's noted that injecting other plugins inside the
config
hook will has no effect, I think we should let the type also saids so to keep users from doing this. It could be very confusing when people didn't see the note.Additional context
What is the purpose of this pull request?
type enhancement
Before submitting the PR, please make sure you do the following
fixes #123
).