Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(create-vite): use quotes for attributes consistently #12383

Merged

Commits on Mar 12, 2023

  1. style(create-vite): use quotes for attributes consistently

    As part of my changes in vitejs#12374, I unintentionally removed the quotes
    for the Vite logos from the vanilla templates, perhaps because the rest
    of the templates didn't need them.
    
    While HTML5 allows no quotes for attribute values if the value doesn't contain
    a space, keeping a consistent style is important for cognitive load when
    reading and maintaining. Hence, I've marked this as a style change.
    
    While not a functional change in these templates, it could be if someone
    later changed the import path to contain a space (perhaps after
    generating a project using the template).
    XanderXAJ committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    4aafa6b View commit details
    Browse the repository at this point in the history