Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terser options types are outdated #17668

Closed
7 tasks done
luc122c opened this issue Jul 12, 2024 · 0 comments · Fixed by #17669
Closed
7 tasks done

Terser options types are outdated #17668

luc122c opened this issue Jul 12, 2024 · 0 comments · Fixed by #17669

Comments

@luc122c
Copy link
Contributor

luc122c commented Jul 12, 2024

Describe the bug

The type definitions for Terser (defined here) are outdated and do not match the source. I'll gladly open a PR to update them, however I notice the line that says "Modified and inlined to avoid extra dependency". I'm not sure what the modifications would be and don't want to overwrite them.

Reproduction

N/A

Steps to reproduce

No response

System Info

System:
    OS: macOS 14.5
    CPU: (20) arm64 Apple M1 Ultra
    Memory: 17.08 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 3.6.3 - ~/.nvm/versions/node/v20.11.0/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
    pnpm: 9.4.0 - ~/.nvm/versions/node/v20.11.0/bin/pnpm
    bun: 1.1.18 - /opt/homebrew/bin/bun
  Browsers:
    Chrome: 126.0.6478.127
    Safari: 17.5

Used Package Manager

pnpm

Logs

No response

Validations

@luc122c luc122c changed the title Terser options are outdated Terser options types are outdated Jul 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant