Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip hmr when script is merely formatted #258

Merged
merged 4 commits into from
Nov 19, 2023

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Sep 19, 2023

Description

This PR adds a check for the updated script's AST during HMR so that if the AST contains merely location or comment changes, the script would be excluded from affectedModules (thus skipping HMR).

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Somehow it's not preserved during `test-build`.
But it's not a big deal for our use case so let's just ignore it.
haoqunjiang and others added 2 commits September 20, 2023 01:16
This refactor is not related to this PR, could be in another commit.
@sxzz sxzz merged commit 8383f49 into vitejs:main Nov 19, 2023
6 checks passed
@aguingand aguingand mentioned this pull request May 6, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants