Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ConntrackCreate & ConntrackUpdate #937

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Adds ConntrackCreate & ConntrackUpdate #937

merged 1 commit into from
Jul 4, 2024

Conversation

aaaaaaaalex
Copy link
Contributor

  • Also refactored setUpNetlinkTestWithKModule in test infrastructure, to reduce redundant NS's created and redundant checks made.

  • Add conntrack protoinfo TCP support + groundwork for other protocols.

    • Will parse TCP protoinfo name+state when reading from kernel.
    • Will just parse other protocol's names and skip the rest.
    • Will only write TCP protoinfo name+state back to kernel, other protocol's groundwork is laid down.

  • Tests to cover the above.

@fasaxc
Copy link
Contributor

fasaxc commented Jan 17, 2024

PR for #918

@aboch
Copy link
Collaborator

aboch commented Jul 3, 2024

LGTM

@aaaaaaaalex please resolve the conflicts

@aaaaaaaalex
Adds ConntrackCreate & ConntrackUpdate
75fde44 
 - Also refactored setUpNetlinkTestWithKModule function to reduce redundant NS's created and checks made.

 - Add conntrack protoinfo TCP support + groundwork for other protocols.

 - Tests to cover the above.
@aaaaaaaalex
Copy link
Contributor Author

@aboch done, thanks

@aboch aboch merged commit aed23db into vishvananda:main Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaaaaaaalex @fasaxc @aboch